feat: use TypeScript directly for Deno runtime, skip bundling by netanelgilad · Pull Request #386 · base44/cli

netanelgilad · 2026-03-09T07:06:43Z

Note

Description

Since Deno supports TypeScript natively, this PR changes the build pipeline to copy deno-runtime/main.ts directly to dist/assets/deno-runtime/main.ts instead of bundling it into a JavaScript file. This removes an unnecessary Bun build step for the Deno runtime, simplifying the build pipeline and avoiding potential bundling artifacts. All references to the Deno runtime asset are updated from .js to .ts accordingly.

Related Issue

Closes #385

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update
Refactoring (no functional changes)
Other (please describe):

Changes Made

infra/build.ts: Added copyDenoRuntime() helper that uses copyFileSync/mkdirSync to copy deno-runtime/main.ts as-is to dist/assets/deno-runtime/main.ts, replacing the previous runBuild() step; updated watch-mode and production build log output to show "Copied" instead of "Rebuilt" for the Deno runtime
infra/build-binaries.ts: Updated required asset path check from dist/assets/deno-runtime/main.js to main.ts
src/core/assets.ts: Updated getDenoWrapperPath() to return the .ts extension instead of .js

Testing

I have tested these changes locally
I have added/updated tests as needed
All tests pass (npm test)

Checklist

My code follows the project's style guidelines
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation (if applicable)
My changes generate no new warnings
I have updated docs/ (AGENTS.md) if I made architectural changes

Additional Notes

The Deno runtime is executed directly by the Deno binary, which has native TypeScript support, making bundling to JS redundant. This change keeps the source TypeScript intact in the distributed assets and removes one Bun build invocation from the pipeline.

_{🤖 Generated by Claude | 2026-03-10 00:00 UTC}

Since Deno supports TypeScript natively, copy deno-runtime/main.ts as-is instead of bundling it to JS. This removes an unnecessary build step and simplifies the pipeline. - Replace Bun bundle step in infra/build.ts with fs.copyFileSync - Update getDenoWrapperPath() to reference main.ts instead of main.js - Update build-binaries.ts prerequisite check accordingly Co-authored-by: Netanel Gilad <netanelgilad@users.noreply.github.com>

github-actions · 2026-03-09T07:07:19Z

🚀 Package Preview Available!

Install this PR's preview build with npm:

npm i @base44-preview/cli@0.0.41-pr.386.7892f13

Prefer not to change any import paths? Install using npm alias so your code still imports base44:

npm i "base44@npm:@base44-preview/cli@0.0.41-pr.386.7892f13"

Or add it to your package.json dependencies:

{
  "dependencies": {
    "base44": "npm:@base44-preview/cli@0.0.41-pr.386.7892f13"
  }
}

📦 Preview Package: @base44-preview/cli@0.0.41-pr.386.7892f13
🔗 View this commit on GitHub

_{Preview published to npm registry — try new features instantly!}

netanelgilad · 2026-03-09T07:10:09Z

@claude are the changes here covered by tests? the tests run on the real dist output with the deno runtime we copied? or is the change not really covered and I need to test it manually?

claude · 2026-03-09T07:10:26Z

Claude finished @netanelgilad's task in 1m 0s —— View job

Test Coverage Analysis for Deno Runtime Changes

Read changed files
Investigate test suite for Deno runtime coverage
Check if tests run against real dist output

Short answer: these changes are NOT covered by automated tests. You'll need to test manually.

Here's the breakdown:

What the testkit does

CLITestkit.ensureTestAssets() (tests/cli/testkit/CLITestkit.ts:264) does copy dist/assets/ into a temporary ~/.base44/ directory before each test run — so the tests genuinely exercise the real dist output including whatever is in dist/assets/deno-runtime/. That part is solid.

Why it doesn't cover this PR

The only consumer of getDenoWrapperPath() is src/cli/commands/dev.ts:17, which passes it to createDevServer(). There is no tests/cli/dev.spec.ts (or any equivalent) — the dev command has zero test coverage. So:

src/core/assets.ts change (.js → .ts path) — not exercised by any test
infra/build.ts change (copyDenoRuntime() replacing runBuild()) — build infra is not unit tested
infra/build-binaries.ts change (checking for main.ts) — same, no tests for binary build verification

What needs manual testing

To verify this PR works correctly, you'd need to:

Run bun run build and confirm dist/assets/deno-runtime/main.ts exists (not main.js)
Run base44 dev in a project with functions and confirm the Deno runtime starts correctly from the .ts file
Optionally run bun run build:binaries and check the asset check passes with main.ts
|

netanelgilad · 2026-03-09T12:10:35Z

@claude merge main (might be shallow clone) and fix any conflicts after the changes that happened in the main

claude · 2026-03-09T12:10:59Z

Claude finished @netanelgilad's task in 1m 24s —— View job

Merged main into PR branch

Analyze request
Fetch latest main (unshallow if needed)
Merge origin/main into current branch
Fix conflict in packages/cli/infra/build-binaries.ts
Push changes

Main had a monorepo migration (#372) that moved everything under packages/cli/. There was one conflict in infra/build-binaries.ts (now packages/cli/infra/build-binaries.ts) where both sides had changed the deno-runtime asset path — main still had main.js while this PR had updated it to main.ts. Kept main.ts as that's the intent of this PR.

All three PR changes are now correctly in their new monorepo locations:

packages/cli/infra/build.ts — copyDenoRuntime() copies main.ts
packages/cli/infra/build-binaries.ts — checks for main.ts
packages/cli/src/core/assets.ts — returns .ts path

Resolved conflict in infra/build-binaries.ts by keeping the PR's `main.ts` change while adopting the monorepo file layout from main. Co-authored-by: Netanel Gilad <netanelgilad@users.noreply.github.com>

artemdemo · 2026-03-17T10:09:25Z

@claude review

claude · 2026-03-17T10:09:43Z

Claude finished @artemdemo's task in 1m 20s —— View job

Code Review

Read changed files
Analyze diff
Post review feedback

Overall: LGTM — clean, correct refactor. The change is well-scoped and the reasoning is sound. Deno has native TypeScript support, so the previous bundling step was redundant.

`packages/cli/infra/build.ts`

copyDenoRuntime() function (build.ts:28-33) — Clean and minimal. Uses mkdirSync(..., { recursive: true }) which is safe to call even if the dir already exists. ✓

One observation: copyDenoRuntime() uses relative ./ paths, which requires the build to be invoked from the packages/cli/ directory. This is consistent with how the existing runBuild() calls work (entrypoints: ["./src/cli/index.ts"], outdir: "./dist/cli"), so no issue there.

Watch mode (build.ts:78): The watch list correctly includes ./deno-runtime so changes to main.ts will trigger copyDenoRuntime(). ✓

`packages/cli/infra/build-binaries.ts`

Prerequisite check (build-binaries.ts:56): Updated from main.js → main.ts. Straightforward. ✓

`packages/cli/src/core/assets.ts`

getDenoWrapperPath() (assets.ts:17): Returns main.ts path. This is consumed by dev.ts:17 and eventually passed to function-manager.ts:129:

spawn("deno", ["run", "--allow-all", this.wrapperPath], { ... })

deno run accepts .ts files natively, so passing the .ts path works correctly. ✓

Potential future concern (not a blocker)

deno-runtime/main.ts is currently self-contained (no local imports). If it ever grows to import from sibling files (e.g., utilities), those files would need to be copied to dist/assets/deno-runtime/ as well — copyDenoRuntime() only copies main.ts. Worth keeping in mind as the Deno runtime evolves, but not an issue today.

As noted in a prior comment, the base44 dev flow has no automated test coverage, so this should be validated manually: run bun run build and confirm dist/assets/deno-runtime/main.ts exists, then run base44 dev in a project with functions to confirm Deno starts correctly.

artemdemo

no objections

kfirstri added this to CLI Development Mar 9, 2026

github-project-automation bot moved this to Backlog in CLI Development Mar 9, 2026

github-actions bot and others added 3 commits March 9, 2026 12:12

chore: merge main (monorepo migration) into PR branch

2758b37

Resolved conflict in infra/build-binaries.ts by keeping the PR's `main.ts` change while adopting the monorepo file layout from main. Co-authored-by: Netanel Gilad <netanelgilad@users.noreply.github.com>

Merge branch 'main' into claude/issue-385-20260309-0658

d54ff5e

Merge branch 'main' into claude/issue-385-20260309-0658

654a238

kfirstri moved this from Backlog to In progress in CLI Development Mar 16, 2026

artemdemo approved these changes Mar 17, 2026

View reviewed changes

github-project-automation bot moved this from In progress to In review in CLI Development Mar 17, 2026

netanelgilad merged commit 8c2cdcb into main Mar 17, 2026
10 checks passed

netanelgilad deleted the claude/issue-385-20260309-0658 branch March 17, 2026 10:17

github-project-automation bot moved this from In review to Done in CLI Development Mar 17, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: use TypeScript directly for Deno runtime, skip bundling#386

feat: use TypeScript directly for Deno runtime, skip bundling#386
netanelgilad merged 4 commits intomainfrom
claude/issue-385-20260309-0658

netanelgilad commented Mar 9, 2026 •

edited by claude bot

Loading

Uh oh!

github-actions bot commented Mar 9, 2026 •

edited

Loading

Uh oh!

netanelgilad commented Mar 9, 2026

Uh oh!

claude bot commented Mar 9, 2026 •

edited

Loading

Uh oh!

netanelgilad commented Mar 9, 2026

Uh oh!

claude bot commented Mar 9, 2026 •

edited

Loading

Uh oh!

artemdemo commented Mar 17, 2026

Uh oh!

claude bot commented Mar 17, 2026 •

edited

Loading

Uh oh!

artemdemo left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

netanelgilad commented Mar 9, 2026 • edited by claude bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Type of Change

Changes Made

Testing

Checklist

Additional Notes

Uh oh!

github-actions bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Package Preview Available!

Uh oh!

netanelgilad commented Mar 9, 2026

Uh oh!

claude bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Coverage Analysis for Deno Runtime Changes

What the testkit does

Why it doesn't cover this PR

What needs manual testing

Uh oh!

netanelgilad commented Mar 9, 2026

Uh oh!

claude bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merged main into PR branch

Uh oh!

artemdemo commented Mar 17, 2026

Uh oh!

claude bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review

packages/cli/infra/build.ts

packages/cli/infra/build-binaries.ts

packages/cli/src/core/assets.ts

Potential future concern (not a blocker)

Uh oh!

artemdemo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netanelgilad commented Mar 9, 2026 •

edited by claude bot

Loading

github-actions bot commented Mar 9, 2026 •

edited

Loading

claude bot commented Mar 9, 2026 •

edited

Loading

claude bot commented Mar 9, 2026 •

edited

Loading

claude bot commented Mar 17, 2026 •

edited

Loading

`packages/cli/infra/build.ts`

`packages/cli/infra/build-binaries.ts`

`packages/cli/src/core/assets.ts`